Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Build Targets #1824

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Update Build Targets #1824

merged 3 commits into from
Mar 22, 2021

Conversation

refs
Copy link
Member

@refs refs commented Mar 19, 2021

What?

Make build target build used to build a binary twice, the second occurrence having symbols for debugging. We split this step in two and added build-all and build-debug targets.

  • build-all now behaves as the previous build target, it will generate 2 binaries, one for debug.
  • build-debug will build a single binary for debugging.

@refs refs requested a review from wkloucek March 19, 2021 09:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

wkloucek
wkloucek approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkloucek wkloucek merged commit 1fa2c5f into master Mar 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-build-target branch March 22, 2021 07:41
ownclouders pushed a commit that referenced this pull request Mar 22, 2021
@wkloucek
commit 1fa2c5f
bdcb459 
Merge: ec0e962 48fe247
Author: Willy Kloucek <[email protected]>
Date:   Mon Mar 22 08:41:20 2021 +0100

    Merge pull request #1824 from owncloud/update-build-target

    Update Build Targets
@fschade fschade mentioned this pull request Mar 29, 2021
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refs @wkloucek