Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CS3 user object fields to store UID and GID #1951

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

ishank011
Copy link
Contributor

No description provided.

@update-docs
Copy link

update-docs bot commented Apr 21, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ishank011 ishank011 force-pushed the uid-gid-user-object branch from be877e1 to 09534c8 Compare April 21, 2021 17:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

22.0% 22.0% Coverage
25.9% 25.9% Duplication

@micbar
Copy link
Contributor

micbar commented May 5, 2021

can you remove the go.mod replace?

@ishank011
Copy link
Contributor Author

@micbar something was broken in reva. Will fix and merge the corresponding commit in reva and then point ocis to the master.

@ishank011 ishank011 force-pushed the uid-gid-user-object branch 4 times, most recently from b403489 to 0d3aba2 Compare June 16, 2021 14:18
@ishank011 ishank011 force-pushed the uid-gid-user-object branch from 0d3aba2 to 6168ee7 Compare June 16, 2021 16:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

21.8% 21.8% Coverage
25.3% 25.3% Duplication

@ishank011 ishank011 marked this pull request as ready for review June 17, 2021 08:35
@micbar
Copy link
Contributor

micbar commented Jun 24, 2021

@ishank011 Reva got updated to v1.9.0 in ocis.

Can you rebase? I would like to merge it before the release.

@micbar micbar mentioned this pull request Jun 24, 2021
23 tasks
@ishank011
Copy link
Contributor Author

@micbar I don't think a rebase is needed. Since the reva version was updated, this should work as is. Can you also review and merge #2199?

@micbar micbar merged commit 34e0877 into owncloud:master Jun 25, 2021
@ishank011 ishank011 deleted the uid-gid-user-object branch June 25, 2021 08:08
ownclouders pushed a commit that referenced this pull request Jun 25, 2021
Merge: 4675c14 6168ee7
Author: Michael Barz <[email protected]>
Date:   Fri Jun 25 10:06:14 2021 +0200

    Merge pull request #1951 from ishank011/uid-gid-user-object

    Use CS3 user object fields to store UID and GID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants