Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dictionary.js for package settings and accounts #2003

Merged
merged 1 commit into from
May 3, 2021
Merged

Added dictionary.js for package settings and accounts #2003

merged 1 commit into from
May 3, 2021

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented May 3, 2021 •
edited
Loading

Description

The dictionary.js file for package settings and accounts, which contains strings that should be synced to transifex but not exist in ui directly, moreover they get loaded for example by API requests

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@AlexAndBear AlexAndBear requested review from JammingBen and kulmann May 3, 2021 08:08
@AlexAndBear AlexAndBear self-assigned this May 3, 2021
@AlexAndBear AlexAndBear changed the title add dictionary.js add dictionary.js for package settings and accounts May 3, 2021
@AlexAndBear AlexAndBear requested a review from butonic May 3, 2021 08:16
@owncloud owncloud deleted a comment from update-docs bot May 3, 2021
@AlexAndBear AlexAndBear changed the title add dictionary.js for package settings and accounts Added dictionary.js for package settings and accounts May 3, 2021
@AlexAndBear AlexAndBear force-pushed the add-dictionary-js branch 2 times, most recently from 3ea0cc3 to f5ce6cf Compare May 3, 2021 08:20
@AlexAndBear AlexAndBear force-pushed the add-dictionary-js branch from f5ce6cf to 115f03d Compare May 3, 2021 08:20
@AlexAndBear AlexAndBear requested a review from fschade May 3, 2021 08:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@AlexAndBear AlexAndBear merged commit c11561b into master May 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-dictionary-js branch May 3, 2021 12:27
ownclouders pushed a commit that referenced this pull request May 3, 2021
commit c11561b
f77dbcb 
Merge: 6ada273 115f03d
Author: Jan Ackermann <[email protected]>
Date:   Mon May 3 14:27:02 2021 +0200

    Merge pull request #2003 from owncloud/add-dictionary-js

    Added dictionary.js for package settings and accounts
@renovate renovate bot mentioned this pull request Jun 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

@kulmann kulmann Awaiting requested review from kulmann

@butonic butonic Awaiting requested review from butonic

@fschade fschade Awaiting requested review from fschade

Assignees

@AlexAndBear AlexAndBear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAndBear @pascalwengerter