Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Removed web suite lists #2105

Merged
merged 1 commit into from
Jun 1, 2021
Merged

[Tests-Only] Removed web suite lists #2105

merged 1 commit into from
Jun 1, 2021

Conversation

kiranparajuli589
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kiranparajuli589 kiranparajuli589 self-assigned this Jun 1, 2021
phil-davis
phil-davis reviewed Jun 1, 2021
View reviewed changes
.drone.star Show resolved Hide resolved
@kiranparajuli589 kiranparajuli589 force-pushed the remove-web-test-suites-list branch 3 times, most recently from 0690b77 to 93cdd4e Compare June 1, 2021 08:18
@phil-davis phil-davis self-requested a review June 1, 2021 08:21
@kiranparajuli589 kiranparajuli589 force-pushed the remove-web-test-suites-list branch from 93cdd4e to 558ad31 Compare June 1, 2021 08:22
@micbar
Copy link
Contributor

micbar commented Jun 1, 2021

@kiranparajuli589 @phil-davis We should keep the full WebUI suite on tagging.

@phil-davis
Copy link
Contributor

@kiranparajuli589 @phil-davis We should keep the full WebUI suite on tagging.

See issue #2107

@phil-davis
Copy link
Contributor

phil-davis commented Jun 1, 2021 •
edited
Loading

https://drone.owncloud.com/owncloud/ocis/5201/19/6
17 scenarios (17 passed)

That looks good. @kiranparajuli589 you can remove the skip stuff, squash and this should be "a good thing"

@kiranparajuli589 kiranparajuli589 force-pushed the remove-web-test-suites-list branch from 710e419 to d441cfb Compare June 1, 2021 10:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

phil-davis
phil-davis reviewed Jun 1, 2021
View reviewed changes
.drone.star Show resolved Hide resolved
phil-davis
phil-davis approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiranparajuli589 kiranparajuli589 merged commit 06da18c into master Jun 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-web-test-suites-list branch June 1, 2021 11:09
ownclouders pushed a commit that referenced this pull request Jun 1, 2021
@kiranparajuli589
commit 06da18c
a193313 
Merge: f419528 d441cfb
Author: PKiran <[email protected]>
Date:   Tue Jun 1 16:54:34 2021 +0545

    Merge pull request #2105 from owncloud/remove-web-test-suites-list

    [Tests-Only] Removed web suite lists
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/5203/43/6
17 scenarios (17 passed)
good - that is the expected number of web smoke tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar

@wkloucek wkloucek Awaiting requested review from wkloucek

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] Remove web suite list from OCIS CI .drone.star
3 participants
@kiranparajuli589 @micbar @phil-davis