Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-only] Tracing ADR #2409

Merged
merged 1 commit into from
Aug 18, 2021
Merged

[docs-only] Tracing ADR #2409

merged 1 commit into from
Aug 18, 2021

Conversation

refs
Copy link
Member

@refs refs commented Aug 17, 2021

No description provided.

@update-docs
Copy link

update-docs bot commented Aug 17, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@refs refs requested review from butonic and C0rby August 17, 2021 11:26
C0rby
C0rby approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think we should still go ahead and trim the logs because IMO there is much unnecessary output.

@refs
Copy link
Member Author

refs commented Aug 18, 2021

I think we should still go ahead and trim the logs because IMO there is much unnecessary output.

Agree with this point. But this is also something that is particular to the way we run and debug things, this way being a single process on a single terminal where logs are aplenty. I wonder the case where logs are piped to files for each service, how much the verbosity would be

@refs refs merged commit 7dac10b into master Aug 18, 2021
@refs refs deleted the adr-traces-2021 branch August 18, 2021 09:16
ownclouders pushed a commit that referenced this pull request Aug 18, 2021
@refs
commit 7dac10b
6282362 
Merge: 3947531 021086e
Author: Alex Unger <[email protected]>
Date:   Wed Aug 18 11:16:12 2021 +0200

    Merge pull request #2409 from owncloud/adr-traces-2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refs @C0rby