Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update accounts, idp, settings JS dependencies #2420

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Update accounts, idp, settings JS dependencies #2420

merged 1 commit into from
Aug 31, 2021

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Aug 19, 2021 •
edited
Loading

Description

  • will supersede a bunch of dependabot PRs
  • bumps ODS in accounts & settings to current version
  • cleaned up (dev)Dependencies in settings

@update-docs
Copy link

update-docs bot commented Aug 19, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter pascalwengerter requested a review from C0rby August 19, 2021 11:03
@C0rby
Copy link
Contributor

C0rby commented Aug 19, 2021

I think you still need to run make generate to make the changes be used.

@pascalwengerter
Copy link
Contributor Author

I think you still need to run make generate to make the changes be used.

I did run make generate in repo root (same goes for the last PR that did something similar) yet there was nothing more to commit both times (which struck me as odd since usually there would be modified embed.go files coming with those changes, but I didn't think too much about it). Could you investigate?

@phil-davis
Copy link
Contributor

Pipeline https://drone.owncloud.com/owncloud/ocis/6447/7/5 died with:

{"level":"error","service":"storage","error":"listen tcp 0.0.0.0:9215: bind: address already in use","time":"2021-08-19T11:07:54.940806083Z","message":"error getting sockets"}

I restarted CI.

@ownclouders
Copy link
Contributor

💥 Acceptance tests settingsUITests failed. The build is cancelled...

1 similar comment
@ownclouders
Copy link
Contributor

💥 Acceptance tests settingsUITests failed. The build is cancelled...

@pascalwengerter pascalwengerter force-pushed the 19082021_js-dependencies branch from d9de747 to d7d46ac Compare August 19, 2021 12:09
@ownclouders
Copy link
Contributor

💥 Acceptance tests settingsUITests failed. The build is cancelled...

@pascalwengerter pascalwengerter force-pushed the 19082021_js-dependencies branch from d7d46ac to 30c2f71 Compare August 20, 2021 10:47
@ownclouders
Copy link
Contributor

💥 Acceptance tests settingsUITests failed. The build is cancelled...

@pascalwengerter pascalwengerter force-pushed the 19082021_js-dependencies branch from 30c2f71 to e44a7d3 Compare August 23, 2021 09:40
@ownclouders
Copy link
Contributor

💥 Acceptance tests settingsUITests failed. The build is cancelled...

@pascalwengerter pascalwengerter force-pushed the 19082021_js-dependencies branch from e44a7d3 to 9deb7be Compare August 30, 2021 15:25
@pascalwengerter pascalwengerter changed the title Update accounts, settings, onlyoffice dependencies Update accounts, idp, settings JS dependencies Aug 30, 2021
@pascalwengerter pascalwengerter force-pushed the 19082021_js-dependencies branch from 9deb7be to cee454d Compare August 30, 2021 16:02
@pascalwengerter pascalwengerter mentioned this pull request Aug 30, 2021
Closed
@pascalwengerter pascalwengerter force-pushed the 19082021_js-dependencies branch from cee454d to b888774 Compare August 30, 2021 16:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pascalwengerter
Copy link
Contributor Author

pascalwengerter commented Aug 30, 2021 •
edited
Loading

@C0rby @kulmann can I get a very careful review from you if CI is happy with this one? Rebased on current master, removed the onlyoffice stuff, refactored dependencies in settings and wildly upgraded dependencies (and pinned nightwatch-based stuff the same way it's done in web for now so CI doesn't break, Florian has a pending fix that allows a nightwatch bump in owncloud/web#5675)

kulmann
kulmann approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 also gave it a try locally, which looked fine as well. 🚀

@pascalwengerter pascalwengerter merged commit 32241b5 into master Aug 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the 19082021_js-dependencies branch August 31, 2021 07:43
ownclouders pushed a commit that referenced this pull request Aug 31, 2021
commit 32241b5
f2846f5 
Merge: d714cda b888774
Author: Pascal Wengerter <[email protected]>
Date:   Tue Aug 31 08:43:49 2021 +0100

    Merge pull request #2420 from owncloud/19082021_js-dependencies

    Update accounts, idp, settings JS dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@C0rby C0rby Awaiting requested review from C0rby

@lookacat lookacat Awaiting requested review from lookacat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pascalwengerter @C0rby @phil-davis @ownclouders @kulmann