Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redirect invalid links to oC Web (#2493) #2512

Merged
merged 1 commit into from
Sep 16, 2021
Merged

fix: redirect invalid links to oC Web (#2493) #2512

merged 1 commit into from
Sep 16, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Sep 15, 2021 •
edited
Loading

Description

Invalid links ending with a slash have not been redirected after #2493. This is cared of in this PR.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested review from butonic and C0rby and removed request for kulmann and pascalwengerter September 15, 2021 16:21
@wkloucek wkloucek mentioned this pull request Sep 15, 2021
Merged
9 tasks
@ownclouders
Copy link
Contributor

💥 Acceptance tests Core-API-Tests-ocis-storage-4 failed. The build is cancelled...

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit 945e315 into master Sep 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_pull_2493 branch September 16, 2021 11:58
ownclouders pushed a commit that referenced this pull request Sep 16, 2021
@wkloucek
commit 945e315
bc78159 
Merge: ab84c4c 09b4850
Author: Willy Kloucek <[email protected]>
Date:   Thu Sep 16 13:58:15 2021 +0200

    Merge pull request #2512 from owncloud/fix_pull_2493

    fix: redirect invalid links to oC Web (#2493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @ownclouders @butonic