make mimetype allow list configurable and add example config #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
wkloucek
force-pushed
the
configure_default_mimetypes
branch
from
72d8b89 to
85267eb
Compare
💥 Acceptance tests Core-API-Tests-ocis-storage-7 failed. The build is cancelled... |
wkloucek
force-pushed
the
configure_default_mimetypes
branch
from
0735e18 to
8fd705e
Compare
💥 Acceptance tests Core-API-Tests-ocis-storage-5 failed. The build is cancelled... |
wkloucek
force-pushed
the
configure_default_mimetypes
branch
2 times, most recently
from
760334d to
e94565f
Compare
refs
suggested changes
Sep 30, 2021
| @@ -13,6 +13,7 @@ node_modules/ | |||
| ocis/ocis | |||
| ocis/cmd/ocis/__debug_bin | |||
| ocis/cmd/ocis/config/ | |||
| config/ | |||
9 tasks
wkloucek
force-pushed
the
configure_default_mimetypes
branch
from
561e977 to
66f430b
Compare
refs
approved these changes
Oct 1, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since cs3org/reva#2095 mime types must be on an allow list to be advertised on the
/app/listendpoint. Additionally one can now add some more information about mime types and select a default application per mime type as requested in #2563.This PR adds a basic default configuration and the possibility to configure the mime types with a config file.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: