Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] fix unexpected passes for cs3org/reva#2086 #2581

Merged
merged 1 commit into from
Oct 6, 2021
Merged

[full-ci] fix unexpected passes for cs3org/reva#2086 #2581

merged 1 commit into from
Oct 6, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Oct 6, 2021

Description

fix unexpected passes for cs3org/reva#2086

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Oct 6, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek changed the title fix unexpected passes for cs3org/reva#2086 [full-ci] fix unexpected passes for cs3org/reva#2086 Oct 6, 2021
@wkloucek wkloucek force-pushed the report_unexpected_passes branch from c979970 to e2a6b5d Compare October 6, 2021 06:21
@wkloucek wkloucek requested review from C0rby and refs October 6, 2021 06:22
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rhafer
rhafer approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wkloucek wkloucek merged commit 21acef4 into master Oct 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the report_unexpected_passes branch October 6, 2021 07:15
ownclouders pushed a commit that referenced this pull request Oct 6, 2021
@wkloucek
commit 21acef4
0c63355 
Merge: c0a20b2 e2a6b5d
Author: Willy Kloucek <[email protected]>
Date:   Wed Oct 6 09:15:44 2021 +0200

    Merge pull request #2581 from owncloud/report_unexpected_passes

    [full-ci] fix unexpected passes for cs3org/reva#2086
@phil-davis
Copy link
Contributor

@wkloucek the link in the tp post points to a cs3org/reva PR.
How did this happen in the oCIS repo?

@wkloucek
Copy link
Contributor Author

wkloucek commented Oct 6, 2021

@wkloucek the link in the tp post points to a cs3org/reva PR. How did this happen in the oCIS repo?

#2520 without full-ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

@C0rby C0rby Awaiting requested review from C0rby

@refs refs Awaiting requested review from refs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @phil-davis @rhafer