Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] release 1.13.0 #2617

Merged
merged 2 commits into from
Oct 13, 2021
Merged

[full-ci] release 1.13.0 #2617

merged 2 commits into from
Oct 13, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Oct 13, 2021

Description

release 1.13.0

@wkloucek wkloucek changed the title release 1.1.3.0 [full-ci] release 1.1.3.0 Oct 13, 2021
CHANGELOG.md Outdated
@@ -1,8 +1,8 @@
# Changelog for [unreleased] (UNRELEASED)
# Changelog for [1.14.0] (2021-10-13)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Changelog for [1.14.0] (2021-10-13)
# Changelog for [1.13.0] (2021-10-13)

CHANGELOG.md Outdated

The following sections list the changes for unreleased.
The following sections list the changes for 1.14.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following sections list the changes for 1.14.0.
The following sections list the changes for 1.13.0.

CHANGELOG.md Outdated

[unreleased]: https://github.com/owncloud/ocis/compare/v1.12.0...master
[1.14.0]: https://github.com/owncloud/ocis/compare/v1.12.0...v1.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[1.14.0]: https://github.com/owncloud/ocis/compare/v1.12.0...v1.14.0
[1.13.0]: https://github.com/owncloud/ocis/compare/v1.12.0...v1.13.0

@wkloucek wkloucek changed the title [full-ci] release 1.1.3.0 [full-ci] release 1.13.0 Oct 13, 2021
@wkloucek
Copy link
Contributor Author

wkloucek commented Oct 13, 2021

~@pascalwengerter we keep it as unreleased since normally you don't know what version you release next ~

@wkloucek
Copy link
Contributor Author

@pascalwengerter we keep it as unreleased since normally you don't know what version you release next

you're right, I fixed it

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't want to change more than the version number (from 14 to 13). In general LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@micbar
Copy link
Contributor

micbar commented Oct 13, 2021

@pascalwengerter @wkloucek editing the changelog on the release branch is not a good idea. It will be generated by CI on master.

@micbar
Copy link
Contributor

micbar commented Oct 13, 2021

But now we can merge it without conflicts.

@micbar micbar merged commit f136a58 into master Oct 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the release-1-13-0 branch October 13, 2021 11:49
ownclouders pushed a commit that referenced this pull request Oct 13, 2021
Merge: 5703a18 3607bbb
Author: Michael Barz <[email protected]>
Date:   Wed Oct 13 13:49:03 2021 +0200

    Merge pull request #2617 from owncloud/release-1-13-0

    [full-ci] release 1.13.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants