Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only]Adjust Expected failure #2980

Merged
merged 1 commit into from
Jan 19, 2022
Merged

[tests-only]Adjust Expected failure #2980

merged 1 commit into from
Jan 19, 2022

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Jan 19, 2022 •
edited
Loading

Description

This PR adjusts the expected failures files after the tests related to the spaces adds personal spaces tag

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@amrita-shrestha amrita-shrestha self-assigned this Jan 19, 2022
@SwikritiT SwikritiT mentioned this pull request Jan 19, 2022
Closed
9 tasks
@amrita-shrestha amrita-shrestha marked this pull request as ready for review January 19, 2022 07:49
@amrita-shrestha amrita-shrestha force-pushed the update-expected-failure branch from d6dc6cd to 84dcdb0 Compare January 19, 2022 07:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

phil-davis
phil-davis approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if CI passes

@phil-davis phil-davis merged commit fdb2f55 into master Jan 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-expected-failure branch January 19, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@amrita-shrestha amrita-shrestha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrita-shrestha @phil-davis