Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump reva version #3515

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Bump reva version #3515

merged 3 commits into from
Apr 12, 2022

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Apr 12, 2022

Description

Bumps reva version and removes forked go-cs3apis

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled...

@kobergj kobergj force-pushed the BumpRevaVersion branch 2 times, most recently from b41d83d to 5f84a6b Compare April 12, 2022 13:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rhafer rhafer mentioned this pull request Apr 12, 2022
Merged
9 tasks
rhafer
rhafer approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. (and seems to fix the cs3apitest flakiness)

@micbar micbar merged commit 0d52d93 into owncloud:master Apr 12, 2022
ownclouders pushed a commit that referenced this pull request Apr 12, 2022
@micbar
commit 0d52d93
b0b5b87 
Merge: 71ce625 0fab27e
Author: Michael Barz <[email protected]>
Date:   Tue Apr 12 17:05:18 2022 +0200

    Merge pull request #3515 from kobergj/BumpRevaVersion

    Bump reva version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

@micbar micbar Awaiting requested review from micbar

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kobergj @ownclouders @rhafer @micbar