Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch micro plugin source for the grpc server plugin #3546

Merged
merged 2 commits into from
Apr 21, 2022
Merged

switch micro plugin source for the grpc server plugin #3546

merged 2 commits into from
Apr 21, 2022

Conversation

wkloucek
Copy link
Contributor

Description

follow up of #3543, possible after micro/plugins#5

Related Issue

  • imports go micro plugins from the new repo

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Apr 19, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek requested a review from kobergj April 19, 2022 14:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek wkloucek requested review from C0rby, butonic and rhafer April 20, 2022 06:26
@butonic butonic merged commit be539f7 into master Apr 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the switch-micro-plugin-source-server branch April 21, 2022 11:43
ownclouders pushed a commit that referenced this pull request Apr 21, 2022
@butonic
commit be539f7
4423488 
Merge: 09baf57 2e696f9
Author: Jörn Friedrich Dreyer <[email protected]>
Date:   Thu Apr 21 13:43:29 2022 +0200

    Merge pull request #3546 from owncloud/switch-micro-plugin-source-server

    switch micro plugin source for the grpc server plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@kobergj kobergj Awaiting requested review from kobergj

@C0rby C0rby Awaiting requested review from C0rby

@rhafer rhafer Awaiting requested review from rhafer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @butonic