Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Bump reva & merge unrestrict combined #3637

Merged
merged 16 commits into from
May 2, 2022
Merged

[full-ci] Bump reva & merge unrestrict combined #3637

merged 16 commits into from
May 2, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Apr 29, 2022

Description

This combines

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@micbar micbar force-pushed the bumpreva-merge-unrestrict branch 3 times, most recently from 99c35b9 to 9405392 Compare April 30, 2022 13:49
@phil-davis
Copy link
Contributor

Note: drone is struggling at the moment! The drone server is getting "random" Error 1040: Too many connections

@micbar micbar force-pushed the bumpreva-merge-unrestrict branch 5 times, most recently from 8442d03 to 53e2e9a Compare April 30, 2022 22:24
@micbar micbar requested a review from phil-davis May 1, 2022 09:07
phil-davis
phil-davis approved these changes May 1, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - merge if you like. I am working on a full commit-id bump, but I can easily rebase that if this is merged first.

@micbar
Copy link
Contributor Author

micbar commented May 1, 2022

Thanks. I will first merge my reva PR, to revert the concurrent share fetching.

@micbar
Copy link
Contributor Author

micbar commented May 1, 2022

Then I will get rid of the replace.

@phil-davis
Copy link
Contributor

@micbar I merged #3636
The core commit id is now up-to-date, so you should have no problem with that. Just rebase this PR (and you won't need to touch .drone.env)

kobergj and others added 15 commits May 2, 2022 09:51
@kobergj @micbar
bump reva
3cb7802 
Signed-off-by: jkoberg <[email protected]>
@kobergj @micbar
use feature core commitid
23c1f15 
Signed-off-by: jkoberg <[email protected]>
@kobergj @micbar
next reva version
c1e7aa3 
Signed-off-by: jkoberg <[email protected]>
@kobergj @micbar
fix audit service
dd9acdc 
Signed-off-by: jkoberg <[email protected]>
@kobergj @micbar
update expected failures
0db6fae 
Signed-off-by: jkoberg <[email protected]>
@kobergj @micbar
decode href in xml response
622e077 
Signed-off-by: jkoberg <[email protected]>
@kobergj @micbar
bump reva again
a86cc5a 
Signed-off-by: jkoberg <[email protected]>
@micbar
handle resource ids better
78a6af3
@micbar
reduce drives in listing of graph /me/drives API
ab71b21
@micbar
fix local api test
5b0988f 
URL decode href before comparing with a given string
@micbar
adapt spaces context
c3511c7
@micbar
omit opaque id correctly
7245c35
@micbar
use reva replace
b629aa6
@micbar
adapt expected failures
1e1016a
@micbar
use reva version with no concurrent share listing
d74e3d1
@micbar micbar force-pushed the bumpreva-merge-unrestrict branch from 8d1cf61 to 0952993 Compare May 2, 2022 07:59
@micbar
Copy link
Contributor Author

micbar commented May 2, 2022

rebase pushed

@micbar micbar marked this pull request as ready for review May 2, 2022 08:00
@micbar micbar requested review from butonic, kulmann and C0rby May 2, 2022 08:00
@micbar micbar force-pushed the bumpreva-merge-unrestrict branch from 0952993 to 469fc3d Compare May 2, 2022 08:07
@kulmann
Copy link
Contributor

kulmann commented May 2, 2022

CI is not happy with downloadById api tests, see https://drone.owncloud.com/owncloud/ocis/11203/23/6

@micbar micbar mentioned this pull request May 2, 2022
Closed
45 tasks
@rhafer rhafer force-pushed the bumpreva-merge-unrestrict branch from 1d19951 to 469fc3d Compare May 2, 2022 09:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.9% 62.9% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit 7988125 into master May 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the bumpreva-merge-unrestrict branch May 2, 2022 09:53
ownclouders pushed a commit that referenced this pull request May 2, 2022
@micbar
commit 7988125
09436a7 
Merge: c878adb 469fc3d
Author: Michael Barz <[email protected]>
Date:   Mon May 2 11:53:01 2022 +0200

    Merge pull request #3637 from owncloud/bumpreva-merge-unrestrict

    [full-ci] Bump reva  & merge unrestrict combined
@micbar micbar mentioned this pull request May 2, 2022
Closed
2 tasks
@butonic butonic mentioned this pull request May 2, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@phil-davis phil-davis phil-davis approved these changes

@butonic butonic Awaiting requested review from butonic

@C0rby C0rby Awaiting requested review from C0rby

@wkloucek wkloucek Awaiting requested review from wkloucek

@individual-it individual-it Awaiting requested review from individual-it

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micbar @phil-davis @kulmann @kobergj