separate machine auth from system auth api key #3654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled... |
|
THX for caring |
butonic
force-pushed
the
remove-secret-in-search-service
branch
from
a479cc1 to
7f58aac
Compare
butonic
force-pushed
the
remove-secret-in-search-service
branch
4 times, most recently
from
49c117f to
86a7913
Compare
butonic
changed the title
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
remove-secret-in-search-service
branch
from
86a7913 to
7a40904
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
remove-secret-in-search-service
branch
from
7a40904 to
783687e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Closed in favor of #3672 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the hardcoded
MachineAuthAPIKeyto make the search service read the key from the config file.cc @janackermann @aduffeck