Get rid of hardcoded admin user uuid #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhafer
force-pushed
the
gen-adminuuid
branch
2 times, most recently
from
2359b63 to
d6e6143
Compare
rhafer
requested review from
wkloucek,
micbar,
phil-davis,
individual-it,
kulmann and
pascalwengerter
as code owners
kobergj
requested changes
May 3, 2022
kobergj
approved these changes
May 3, 2022
|
💥 Acceptance test Core-API-Tests-ocis-storage-3 failed. Further test are cancelled... |
rhafer
force-pushed
the
gen-adminuuid
branch
2 times, most recently
from
2923dc4 to
50b6c02
Compare
The reva and idp users are service users and don't need any roles assigned. They currently used for performing LDAP searches.
The UUID is generated by `ocs init` now and stored in the config file. To avoid that every ocis install uses the same UUID Closes: owncloud#3524
Also let the top-level ocis config validator error out if admin_user_id is unset at start.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UUID is generated by
ocs initnow and stored in the config file. To avoid that every ocis install uses the same UUIDRelated Issue