Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deployment examples #3690

Merged
merged 7 commits into from
May 5, 2022
Merged

fix deployment examples #3690

merged 7 commits into from
May 5, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented May 5, 2022 •
edited
Loading

Description

  • fix deployment examples:
    • oCIS Hello
    • oCIS with S3NG storage driver
    • oCIS with WOPI server
  • brings back the app provider (/app/list, /app/edit, app/new) to the frontend in order to fix the wopi integration

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented May 5, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek mentioned this pull request May 5, 2022
Closed
45 tasks
@ownclouders
Copy link
Contributor

ownclouders commented May 5, 2022 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-4 failed. Further test are cancelled...

@wkloucek wkloucek marked this pull request as ready for review May 5, 2022 11:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

butonic
butonic reviewed May 5, 2022
View reviewed changes
extensions/frontend/pkg/revaconfig/config.go
Comment on lines +80 to +84
// this reva service called "appprovider" comes from
// `internal/http/services/appprovider` and is a translation
// layer from the grpc app registry to http, used by eg. ownCloud Web
// It should not be confused with `internal/grpc/services/appprovider`
// which is currently only has only the driver for the CS3org WOPI server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this is confusing we can probably clarify this in the docs for the extensions/app-provider?

@butonic butonic merged commit d2b0cb8 into owncloud:master May 5, 2022
ownclouders pushed a commit that referenced this pull request May 5, 2022
@butonic
commit d2b0cb8
c58c1b1 
Merge: 15f7c00 6e3752b
Author: Jörn Friedrich Dreyer <[email protected]>
Date:   Thu May 5 12:31:41 2022 +0000

    Merge pull request #3690 from wkloucek/fix-deployment-examples

    fix deployment examples
@wkloucek wkloucek deleted the fix-deployment-examples branch May 20, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@micbar micbar Awaiting requested review from micbar

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @ownclouders @butonic