Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes to searching in shares #3725

Merged
merged 8 commits into from
May 11, 2022
Merged

Conversation

aduffeck
Copy link
Contributor

@aduffeck aduffeck commented May 6, 2022

This PR fixes a problem when searching in sharey by making the search results relative to the mountpoint space instead of the grant space.
It also adds more debug logs and changes the search to still continue and return whatever it can find in case there's a problem searching within one space.

Fixes #3701
Fixes #3700

@ownclouders
Copy link
Contributor

ownclouders commented May 6, 2022

💥 Acceptance test cs3ApiTests-ocis failed. Further test are cancelled...

@aduffeck aduffeck force-pushed the search-grants branch 2 times, most recently from 5921270 to 03a7126 Compare May 10, 2022 08:12
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some open questions, rest looks 👍

extensions/search/pkg/search/index/index.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@butonic butonic merged commit 8e5130b into owncloud:master May 11, 2022
@butonic butonic deleted the search-grants branch May 11, 2022 09:32
ownclouders pushed a commit that referenced this pull request May 11, 2022
Merge: 575312c ba249c1
Author: Jörn Friedrich Dreyer <[email protected]>
Date:   Wed May 11 09:31:57 2022 +0000

    Merge pull request #3725 from aduffeck/search-grants

    More fixes to searching in shares
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search is case-sensitive Search works incorrect after MOVE request
4 participants