-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user autoprovisioning via libreGraph #3860
Conversation
They were also added by the ExtractAccountUUID for the /drives endpoint. We'll need some on other endpoints as well (for automatic user provisioning).
When trying to create a user that already exist return a proper error, that clients can check for.
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
If applicapable, in case "new" env's are coming in, do not forget to give them a description and a default. |
There are no new config settings coming in with this. PR. I am still checking whether other parts of the docs need updating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some points, but looks good in general!
When removing the accounts service we lost the user autoprovision feature. This re-introduces it. When autoprovisioning is enabled (via PROXY_AUTOPROVISION_ACCOUNTS, as in the past) accounts that are not resolvable via cs3 will be provsioned via the libregraph API. Closes: owncloud#3540
Co-authored-by: David Christofas <[email protected]>
Co-authored-by: kobergj <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Description
When removing the accounts service we lost the user autoprovision feature. This re-introduces it. When autoprovisioning is enabled (via PROXY_AUTOPROVISION_ACCOUNTS, as in the past) accounts that are not resolvable via cs3 will be provsioned via the libregraph API.
Related Issue:
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: