Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deployments] Add specific LDAP_GROUP_BASE_DN and LDAP_USER_BASE_DN needed for tests #3869

Merged
merged 1 commit into from
May 25, 2022
Merged

[deployments] Add specific LDAP_GROUP_BASE_DN and LDAP_USER_BASE_DN needed for tests #3869

merged 1 commit into from
May 25, 2022

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented May 25, 2022

Description

In the tests, LDAP_GROUP_BASE_DN and LDAP_USER_BASE_DN are different than ou=groups,dc=owncloud,dc=com and ou=users,dc=owncloud,dc=com respectively. Due to this, running parallel deployment tests locally was not possible.

In this PR, I have added LDAP_GROUP_BASE_DN and LDAP_USER_BASE_DN with necessary values to the testing/docker-compose-additions.yml.

Related Issue

Running parallel deployment tests locally was not successful

Motivation and Context

How Has This Been Tested?

  • test environment: local

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this May 25, 2022
@saw-jan saw-jan requested a review from wkloucek May 25, 2022 07:04
wkloucek
wkloucek approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wkloucek wkloucek merged commit d399f7b into master May 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the extra-envs-for-testing branch May 25, 2022 07:11
ownclouders pushed a commit that referenced this pull request May 25, 2022
@wkloucek
commit d399f7b
3053c01 
Merge: 48dfa52 0eb19fc
Author: Willy Kloucek <[email protected]>
Date:   Wed May 25 09:11:10 2022 +0200

    Merge pull request #3869 from owncloud/extra-envs-for-testing

    [deployments] Add specific LDAP_GROUP_BASE_DN and LDAP_USER_BASE_DN needed for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

Assignees

@saw-jan saw-jan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saw-jan @wkloucek