Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error log for "could not get user by claim" error #4227

Merged
merged 1 commit into from
Jul 20, 2022
Merged

improve error log for "could not get user by claim" error #4227

merged 1 commit into from
Jul 20, 2022

Conversation

wkloucek
Copy link
Contributor

Description

Enhancement: Improve error log for "could not get user by claim" error

We've improved the error log for "could not get user by claim" error where
previously only the "nil" error has been logged. Now we're logging the
message from the transport.

Related Issue

Motivation and Context

Helps debugging

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek requested review from rhafer, butonic and kobergj July 19, 2022 11:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit 14c9134 into owncloud:master Jul 20, 2022
@wkloucek wkloucek deleted the improve-error-by-claim branch July 20, 2022 05:02
ownclouders pushed a commit that referenced this pull request Jul 20, 2022
@wkloucek
commit 14c9134
3d4f38b 
Merge: 29b9ab8 8312803
Author: Willy Kloucek <[email protected]>
Date:   Wed Jul 20 07:02:11 2022 +0200

    Merge pull request #4227 from wkloucek/improve-error-by-claim

    improve error log for "could not get user by claim" error
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@rhafer rhafer Awaiting requested review from rhafer

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @kobergj