[full-ci] [tests-only] Added test for creating group with case sensitive #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grgprarup
force-pushed
the
move-graph-test-to-ocis-local
branch
2 times, most recently
from
170584b to
02dff34
Compare
grgprarup
force-pushed
the
move-graph-test-to-ocis-local
branch
2 times, most recently
from
7125ae5 to
3842b41
Compare
grgprarup
requested review from
wkloucek,
micbar,
phil-davis and
individual-it
as code owners
grgprarup
requested review from
kiranparajuli589,
amrita-shrestha and
SwikritiT
| And group "<group_id1>" has been created | ||
| When the administrator creates a group "<group_id2>" using the GraphApi | ||
| And the administrator creates a group "<group_id3>" using the GraphApi | ||
| Then the HTTP status code of responses on all endpoints should be "500" |
There was a problem hiding this comment.
is 500 really the reply we want?
There was a problem hiding this comment.
500 is the actual current behavior of graph API for creating an existing user or group, as mentioned in comment #3516 (comment) the expected code must be 4XX
We have an issue reported here #3516 and mentioned the behavior in #3247.
tests/acceptance/features/apiGraph/createGroupCaseSensitive.feature
Outdated
Show resolved
Hide resolved
grgprarup
force-pushed
the
move-graph-test-to-ocis-local
branch
from
3842b41 to
bda3407
Compare
individual-it
approved these changes
Aug 22, 2022
grgprarup
force-pushed
the
move-graph-test-to-ocis-local
branch
4 times, most recently
from
403774a to
7e501b0
Compare
kiranparajuli589
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
lgtm 👍 ci was failing at https://drone.owncloud.com/owncloud/ocis/14751/3/3, restarted
individual-it
approved these changes
Aug 22, 2022
grgprarup
force-pushed
the
move-graph-test-to-ocis-local
branch
from
7e501b0 to
bcf6001
Compare
|
Need to rebase and push after bump PR #4434 is merged. |
grgprarup
force-pushed
the
move-graph-test-to-ocis-local
branch
from
edafcc3 to
567e60e
Compare
phil-davis
approved these changes
Aug 24, 2022
grgprarup
force-pushed
the
move-graph-test-to-ocis-local
branch
from
567e60e to
d33117e
Compare
grgprarup
force-pushed
the
move-graph-test-to-ocis-local
branch
from
d33117e to
07af854
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Group names are case insensitive with oCIS, we cannot create groups with the same name but different lower and upper cases. So, tests to check group creation with different lower and upper cases are added as suggested in #4291 (comment)
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: