[full-ci][tests-only]Run ocis tests without testing-app #4560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-shrestha
force-pushed
the
runOcisWithoutTestingAppCache
branch
4 times, most recently
from
6a3b6c9 to
d78008f
Compare
SwikritiT
force-pushed
the
runOcisWithoutTestingAppCache
branch
from
1665225 to
03c481a
Compare
11 tasks
SwikritiT
force-pushed
the
runOcisWithoutTestingAppCache
branch
from
a876b69 to
3ee5c33
Compare
SwikritiT
changed the title
SwikritiT
requested review from
wkloucek,
micbar,
phil-davis and
individual-it
as code owners
SwikritiT
force-pushed
the
runOcisWithoutTestingAppCache
branch
from
3ee5c33 to
61d6c5b
Compare
17 tasks
phil-davis
reviewed
Sep 21, 2022
| @@ -671,7 +671,6 @@ def localApiTests(ctx, storage, suite, accounts_hash_difficulty = 4): | |||
| restoreBuildArtifactCache(ctx, "ocis-binary-amd64", "ocis/bin") + | |||
| ocisServer(storage, accounts_hash_difficulty) + | |||
| restoreBuildArtifactCache(ctx, "testrunner", dirs["core"]) + | |||
| restoreBuildArtifactCache(ctx, "testing_app", dirs["testing_app"]) + | |||
There was a problem hiding this comment.
Can we remove SKELETON_DIR at line 684?
| @@ -761,7 +760,6 @@ def coreApiTests(ctx, part_number = 1, number_of_parts = 1, storage = "ocis", ac | |||
| restoreBuildArtifactCache(ctx, "ocis-binary-amd64", "ocis/bin") + | |||
| ocisServer(storage, accounts_hash_difficulty) + | |||
| restoreBuildArtifactCache(ctx, "testrunner", dirs["core"]) + | |||
| restoreBuildArtifactCache(ctx, "testing_app", dirs["testing_app"]) + | |||
There was a problem hiding this comment.
Can we remove SKELETON_DIR at line 773?
| @@ -879,7 +877,6 @@ def uiTestPipeline(ctx, filterTags, early_fail, runPart = 1, numberOfParts = 1, | |||
| ocisServer(storage, accounts_hash_difficulty) + | |||
| waitForSeleniumService() + | |||
| waitForMiddlewareService() + | |||
| restoreBuildArtifactCache(ctx, "testing_app", dirs["testing_app"]) + | |||
There was a problem hiding this comment.
Can we remove TESTING_DATA_DIR at line 889?
There was a problem hiding this comment.
Also, cloneCoreRepos() has git clone of https://github.com/owncloud/testing.git
Can that be removed?
|
NOTE: We need |
SwikritiT
force-pushed
the
runOcisWithoutTestingAppCache
branch
from
5595539 to
8454781
Compare
|
I've not removed the cloning of the testing app as it is need for parallel deployment |
SwikritiT
force-pushed
the
runOcisWithoutTestingAppCache
branch
from
8454781 to
447d8c5
Compare
individual-it
approved these changes
Sep 26, 2022
SwikritiT
force-pushed
the
runOcisWithoutTestingAppCache
branch
from
447d8c5 to
08826a6
Compare
SwikritiT
force-pushed
the
runOcisWithoutTestingAppCache
branch
from
08826a6 to
a9c2203
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ownclouders
pushed a commit
that referenced
this pull request
Sep 27, 2022
Author: Amrita <[email protected]> Date: Tue Sep 27 16:45:43 2022 +0545 [full-ci][tests-only]Run ocis tests without testing-app (#4560) * Run ocis tests without testing-app * add failing tests in expected to fail Co-authored-by: Swikriti Tripathi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the cloning of the testing app , as it's not really needed here