Validate Space Names #4955
Merged
Validate Space Names #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobergj
force-pushed
the
ValidateSpaceNames
branch
from
7df292e to
1396a6b
Compare
kobergj
force-pushed
the
ValidateSpaceNames
branch
2 times, most recently
from
f871d73 to
cdad14c
Compare
|
💥 Acceptance test settingsUITests failed. Further test are cancelled... |
|
💥 Acceptance test Core-API-Tests-ocis-storage-8 failed. Further test are cancelled... |
Signed-off-by: jkoberg <[email protected]>
kobergj
force-pushed
the
ValidateSpaceNames
branch
from
cdad14c to
9f9fe8f
Compare
fschade
reviewed
Nov 2, 2022
Co-authored-by: Michael Barz <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
fschade
approved these changes
Nov 3, 2022
|
https://drone.owncloud.com/owncloud/ocis/16604 is green, force merging |
ownclouders
pushed a commit
that referenced
this pull request
Nov 3, 2022
Author: kobergj <[email protected]> Date: Thu Nov 3 11:39:02 2022 +0100 Validate Space Names (#4955) * validate space names Signed-off-by: jkoberg <[email protected]> * Update services/graph/pkg/service/v0/drives.go Co-authored-by: Michael Barz <[email protected]> Signed-off-by: jkoberg <[email protected]> Co-authored-by: Michael Barz <[email protected]>
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now return
BAD REQUESTwhen space names are/,\,.,\\,:,?,*,",>,<,|)Additionally leading and trailing spaces will be removed silently.
fixes this: #4925