Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lower default access / id / refresh token lifespans #5077

Merged
merged 3 commits into from
Nov 21, 2022
Merged

lower default access / id / refresh token lifespans #5077

merged 3 commits into from
Nov 21, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 18, 2022 •
edited
Loading

Description

We've lowered the IDP token lifespans to more reasonable durations.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Nov 18, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

micbar
micbar approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkloucek wkloucek marked this pull request as ready for review November 21, 2022 08:41
@wkloucek @micbar
Update changelog
018cc5b 
Co-authored-by: Michael Barz <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micbar micbar merged commit f3667b1 into owncloud:master Nov 21, 2022
ownclouders pushed a commit that referenced this pull request Nov 21, 2022
@micbar
commit f3667b1
823b784 
Merge: 7da519a 018cc5b
Author: Michael Barz <[email protected]>
Date:   Mon Nov 21 14:50:25 2022 +0100

    Merge pull request #5077 from wkloucek/lower-default-idp-lifespans

    lower default access / id / refresh token lifespans
@wkloucek wkloucek deleted the lower-default-idp-lifespans branch November 21, 2022 14:54
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
@ScharfViktor ScharfViktor mentioned this pull request Nov 28, 2022
Closed
49 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@butonic butonic Awaiting requested review from butonic

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @micbar