[full-ci] add identitySet displayName property to the group and user sets #5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
fschade
changed the title
fschade
force-pushed
the
drive-group-user-info
branch
from
0063bd7 to
96d1b54
Compare
fix goimports
fschade
force-pushed
the
drive-group-user-info
branch
from
96d1b54 to
0a97af2
Compare
|
SonarCloud Quality Gate failed. |
|
Tested with Web, works perfectly 👍 Can't review the code though. |
ownclouders
pushed a commit
that referenced
this pull request
Jan 10, 2023
Author: Florian Schade <[email protected]> Date: Tue Jan 10 15:42:13 2023 +0100 [full-ci] add identitySet displayName property to the group and user sets (#5347) * add identitySet displayName property to the group and user sets
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The graph identity spec intended the displayName property for identity types.
The value is used in the graph drives endpoint for a single identitySet object.
This PR adds that value to the groups and users sets.
Related Issue
Motivation and Context
the new admin ui in web needs to list details about each user and group, therefore to reduce requests the property has to be part of the drive response.