Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add api tests to assign role using graph api #5579

Merged
merged 1 commit into from
Feb 24, 2023
Merged

[tests-only][full-ci]Add api tests to assign role using graph api #5579

merged 1 commit into from
Feb 24, 2023

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Feb 15, 2023 •
edited
Loading

Description

This scenario adds scenario assign a role to a user using the graph API and check if its correctly listed by the graph API and and by the settings API

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Feb 15, 2023
@amrita-shrestha amrita-shrestha mentioned this pull request Feb 15, 2023
Closed
4 tasks
@amrita-shrestha amrita-shrestha force-pushed the add-assignRole-using-graph-api branch 2 times, most recently from 1f7c24f to 2263b23 Compare February 15, 2023 11:53
@amrita-shrestha amrita-shrestha marked this pull request as ready for review February 15, 2023 11:56
@amrita-shrestha amrita-shrestha force-pushed the add-assignRole-using-graph-api branch 2 times, most recently from 084144c to 879452a Compare February 16, 2023 03:48
@amrita-shrestha
Copy link
Contributor Author

amrita-shrestha commented Feb 16, 2023 •
edited
Loading

blocked until this issue confirm as a bug from the developer side #5583?

@amrita-shrestha amrita-shrestha force-pushed the add-assignRole-using-graph-api branch 2 times, most recently from 4958b9a to 278e1d5 Compare February 17, 2023 06:33
@amrita-shrestha amrita-shrestha force-pushed the add-assignRole-using-graph-api branch from 278e1d5 to 9cc00de Compare February 20, 2023 04:04
@amrita-shrestha amrita-shrestha force-pushed the add-assignRole-using-graph-api branch from 9cc00de to c32484d Compare February 20, 2023 04:13
SagarGi
SagarGi reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 if CI is green

@amrita-shrestha amrita-shrestha force-pushed the add-assignRole-using-graph-api branch 3 times, most recently from 6669886 to 9a97d3b Compare February 21, 2023 09:23
@amrita-shrestha amrita-shrestha force-pushed the add-assignRole-using-graph-api branch from 9a97d3b to 124530e Compare February 21, 2023 09:32
SagarGi
SagarGi reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM 👍

@amrita-shrestha amrita-shrestha force-pushed the add-assignRole-using-graph-api branch from 124530e to c6b220a Compare February 23, 2023 04:12
@amrita-shrestha amrita-shrestha force-pushed the add-assignRole-using-graph-api branch from c6b220a to 2e3e45a Compare February 23, 2023 07:40
@amrita-shrestha amrita-shrestha force-pushed the add-assignRole-using-graph-api branch from 2e3e45a to 0b71d10 Compare February 23, 2023 09:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SwikritiT
SwikritiT reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@individual-it individual-it merged commit 5faceb0 into master Feb 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-assignRole-using-graph-api branch February 24, 2023 11:08
ownclouders pushed a commit that referenced this pull request Feb 24, 2023
@individual-it
commit 5faceb0
4199468 
Merge: 5ad8e28 0b71d10
Author: Artur Neumann <[email protected]>
Date:   Fri Feb 24 16:53:33 2023 +0545

    Merge pull request #5579 from owncloud/add-assignRole-using-graph-api

    [tests-only][full-ci]Add api tests to assign role using graph api
@saw-jan saw-jan mentioned this pull request Feb 28, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@individual-it individual-it individual-it approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@saw-jan saw-jan Awaiting requested review from saw-jan

@SagarGi SagarGi Awaiting requested review from SagarGi

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amrita-shrestha @individual-it @grgprarup @SwikritiT @SagarGi @saw-jan