[full-ci] Implement backchannel logout #6007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
E2E tests failed: https://drone.owncloud.com/owncloud/ocis/21457/88/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/21457/tracing/folder-alice-2023-4-18-10-34-41.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/21457/tracing/folder-brian-2023-4-18-10-34-55.zip |
dragonchaser
force-pushed
the
backchannellogout
branch
2 times, most recently
from
2ad9053 to
f4e8353
Compare
dragonchaser
force-pushed
the
backchannellogout
branch
7 times, most recently
from
ab95306 to
052e836
Compare
dragonchaser
changed the title
dragonchaser
force-pushed
the
backchannellogout
branch
from
a5fecdc to
7b79a27
Compare
kobergj
requested changes
Apr 19, 2023
rhafer
suggested changes
Apr 19, 2023
dragonchaser
force-pushed
the
backchannellogout
branch
from
a4dcf5f to
24c0dd4
Compare
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
dragonchaser
force-pushed
the
backchannellogout
branch
from
24c0dd4 to
9ce6048
Compare
Signed-off-by: Christian Richter <[email protected]>
dragonchaser
force-pushed
the
backchannellogout
branch
from
9ce6048 to
30bcf32
Compare
Co-authored-by: Ralf Haferkamp <[email protected]> Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
dragonchaser
force-pushed
the
backchannellogout
branch
from
558ad10 to
7b1be94
Compare
kobergj
approved these changes
Apr 20, 2023
Co-authored-by: Julian Koberg <[email protected]> Signed-off-by: Christian Richter <[email protected]>
dragonchaser
force-pushed
the
backchannellogout
branch
from
269d31a to
a6ced1f
Compare
rhafer
approved these changes
Apr 20, 2023
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Apr 20, 2023
[full-ci] Implement backchannel logout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an endpoint for the backchannel logout
/backchannel_logout.It can be triggered via a POST request with a special crafted logout token see: https://openid.net/specs/openid-connect-backchannel-1_0.html section 2.4 for the structure.
NOTE: we have added a special http-handler wrapper to the proxy to intercept predefined routes in the proxy before they are passed on to the services! https://github.com/dragonchaser/ocis/blob/backchannellogout/services/proxy/pkg/command/server.go#L200. In future this should be used for terminating stuff like oidc-well-knowns to avoid implementation as middlewares.
refs #3521