Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search #6268

Merged
merged 6 commits into from
May 12, 2023
Merged

Improve search #6268

merged 6 commits into from
May 12, 2023

Conversation

aduffeck
Copy link
Contributor

This PR improves and fixes the search service:

  1. We no longer return results from disabled spaces (fixes Files and folders of disabled spaces appear in search #6201)
  2. We fixed a performance regression with big indexes caused by prefix queries which got lost during the experimental-> master merge
  3. The sub-searches in the different spaces are now done concurrently

@update-docs
Copy link

update-docs bot commented May 10, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented May 10, 2023 •
edited
Loading

💥 Acceptance test localApiTests-apiAsyncUpload-ocis failed. Further test are cancelled...

@aduffeck aduffeck force-pushed the improve-search branch 8 times, most recently from 1ed637a to 4953d9d Compare May 10, 2023 13:39
fschade
fschade approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two tiny findings, totally optional. LGTM

services/search/pkg/search/service.go Outdated Show resolved Hide resolved
services/search/pkg/search/service.go Show resolved Hide resolved
@aduffeck aduffeck force-pushed the improve-search branch 2 times, most recently from fe42915 to 4953d9d Compare May 12, 2023 08:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.5% 84.5% Coverage
0.0% 0.0% Duplication

@aduffeck aduffeck merged commit 32014ba into owncloud:master May 12, 2023
ownclouders pushed a commit that referenced this pull request May 12, 2023
@aduffeck
Merge pull request #6268 from aduffeck/improve-search
e7e4dfa 
Improve search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files and folders of disabled spaces appear in search
3 participants
@aduffeck @ownclouders @fschade