-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idp: Use the UUID attribute for computing the "sub" claim #6326
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
@rhafer the real change seems to be very small. which 3rd party libs did you bump? |
Needs a changelog, otherwise it seems to be fine. |
@micbar only libregraph/lico, but that itself bumped quite a few dependencies since with the 0.60.0 release. If you prefer I can apply the fix to lico 0.59.4, that wouldn't cause as many dependency bumps. |
libregraph/lico#95 got merged meanwhile. I'll remove my fork and bump to lico latest master. |
ab6be5e
to
9736599
Compare
This avoids that recreating the user with the same name will create the same "sub" claim. Even though it gets a new UUID Fixes: owncloud#904
This is need for getting this fix: libregraph/lico#95
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This avoids that recreating the user with the same name will create the
same "sub" claim. Even though it gets a new UUID
Fixes: #904