Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix disable users by group #6435

Merged
merged 1 commit into from
Jun 5, 2023
Merged

fix disable users by group #6435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/fix-disable-user.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Fix error message when disabling users

When we disable users by adding them to a group we do not need to update the user entry.

https://github.com/owncloud/ocis/pull/6435
2 changes: 1 addition & 1 deletion services/graph/pkg/identity/ldap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,7 +1178,7 @@ func (i *LDAP) updateAccountEnabledState(logger log.Logger, accountEnabled bool,
} else {
err = i.disableUser(logger, e.DN)
}
updateNeeded = true
updateNeeded = false
}

return updateNeeded, err
Expand Down