-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] [full-ci] removed scenario related to federated share #6511
[tests-only] [full-ci] removed scenario related to federated share #6511
Conversation
Scenario Outline: federated sharee for files | ||
Given using OCS API version "<ocs-api-version>" | ||
When user "Alice" gets the sharees using the sharing API with parameters | ||
| search | test@localhost | | ||
| itemType | file | | ||
Then the OCS status code should be "<ocs-status>" | ||
And the HTTP status code should be "<http-status>" | ||
And the "exact users" sharees returned should be empty | ||
And the "users" sharees returned should be empty | ||
And the "exact groups" sharees returned should be empty | ||
And the "groups" sharees returned should be empty | ||
And the "exact remotes" sharees returned should be | ||
| test@localhost | 6 | test@localhost | | ||
And the "remotes" sharees returned should be empty | ||
Examples: | ||
| ocs-api-version | ocs-status | http-status | | ||
| 1 | 100 | 200 | | ||
| 2 | 200 | 200 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ScharfViktor Should we remove these scenarios related to federated share (federated share is not implemented in oCIS yet but will be in the future: #1329)?
IMO, these can be removed because these scenarios might not describe the federation share the way oCIS will implement it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if these tests will not work in ocis when we implement federated share, please merge this PR
I left this test because I thought they would be able to work in ocis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove these. As we have a lot of tests in core regarding the federation that hasn't been transferred to ocis yet. When the feature will be implemented, we can copy and paste the implementation from core if the federate implementation in ocis works according to that. If the implementation in ocis will not work according to the implementation in core these scenarios aren't relevant anyway
8914fb6
to
dc6211f
Compare
dc6211f
to
cb37871
Compare
Kudos, SonarCloud Quality Gate passed! |
Description
This PR removes the test scenarios related to
federated shares
.Related Issue
Screenshots (if appropriate):
Types of changes
Checklist: