Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] removed scenario related to federated share #6511

Merged

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Jun 13, 2023

Description

This PR removes the test scenarios related to federated shares.

  • Scenario Outline: federated sharee for files
  • Scenario Outline: federated sharee for calendars not allowed

Related Issue

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya self-assigned this Jun 13, 2023
@PrajwolAmatya PrajwolAmatya marked this pull request as ready for review June 14, 2023 03:41
Comment on lines -164 to -181
Scenario Outline: federated sharee for files
Given using OCS API version "<ocs-api-version>"
When user "Alice" gets the sharees using the sharing API with parameters
| search | test@localhost |
| itemType | file |
Then the OCS status code should be "<ocs-status>"
And the HTTP status code should be "<http-status>"
And the "exact users" sharees returned should be empty
And the "users" sharees returned should be empty
And the "exact groups" sharees returned should be empty
And the "groups" sharees returned should be empty
And the "exact remotes" sharees returned should be
| test@localhost | 6 | test@localhost |
And the "remotes" sharees returned should be empty
Examples:
| ocs-api-version | ocs-status | http-status |
| 1 | 100 | 200 |
| 2 | 200 | 200 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScharfViktor Should we remove these scenarios related to federated share (federated share is not implemented in oCIS yet but will be in the future: #1329)?
IMO, these can be removed because these scenarios might not describe the federation share the way oCIS will implement it.

Copy link
Contributor

@ScharfViktor ScharfViktor Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these tests will not work in ocis when we implement federated share, please merge this PR
I left this test because I thought they would be able to work in ocis

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove these. As we have a lot of tests in core regarding the federation that hasn't been transferred to ocis yet. When the feature will be implemented, we can copy and paste the implementation from core if the federate implementation in ocis works according to that. If the implementation in ocis will not work according to the implementation in core these scenarios aren't relevant anyway

@saw-jan saw-jan requested a review from ScharfViktor June 14, 2023 04:18
@PrajwolAmatya PrajwolAmatya requested a review from saw-jan June 16, 2023 10:36
@PrajwolAmatya PrajwolAmatya force-pushed the remove-scenario-related-to-federated-root-shares branch from 8914fb6 to dc6211f Compare June 16, 2023 10:45
@PrajwolAmatya PrajwolAmatya force-pushed the remove-scenario-related-to-federated-root-shares branch from dc6211f to cb37871 Compare June 16, 2023 10:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@PrajwolAmatya PrajwolAmatya merged commit 997cf54 into master Jun 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the remove-scenario-related-to-federated-root-shares branch June 16, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants