[tests-only][ociswrapper] Fix oCIS restart when it exits unexpectedly during startup

[saw-jan]

Description

Improves:

• restart ocis server if it exists with error during startup
• do not panic if the process is already finished while stopping the process
• mark server ready if the server sends the response

Related Issue

Part of #6850

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[phil-davis]

Seems OK. I suppose that the actual testing software will see the error (as a 500 status returned by the API, or...) and will be able to make the decision if it retries, or fails the test.
We do want to know when "bad things" go wrong and be able to see test failures. We don't want to actually end up hiding "intermittent nasty problems" by doing retries.

[saw-jan]

Seems OK. I suppose that the actual testing software will see the error (as a 500 status returned by the API, or...) and will be able to make the decision if it retries, or fails the test. We do want to know when "bad things" go wrong and be able to see test failures. We don't want to actually end up hiding "intermittent nasty problems" by doing retries.

yeah, the ociswrapper only retries if the ocis server command terminates

[saw-jan]

yeah, the ociswrapper only retries if the ocis server command terminates

this was not fully true. Now the recent commits fix this.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information