Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Extended test coverage for depth:infinity enabled config #7397

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[tests-only] Extended test coverage for depth:infinity enabled config #7397

merged 1 commit into from
Nov 27, 2023

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Oct 3, 2023 •
edited
Loading

Description

Extended test coverage for depth:infinity enabled config.

Related Issue

Blocked until #7359

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan added the QA:team label Oct 3, 2023
@saw-jan saw-jan self-assigned this Oct 3, 2023
@saw-jan saw-jan mentioned this pull request Oct 4, 2023
Merged
9 tasks
@saw-jan saw-jan force-pushed the tests/test-coverage-depth-infinity branch 2 times, most recently from 45e75f9 to 0b7ddef Compare October 4, 2023 07:21
@saw-jan saw-jan force-pushed the tests/test-coverage-depth-infinity branch from 0b7ddef to 1906b5b Compare October 26, 2023 04:55
@saw-jan saw-jan force-pushed the tests/test-coverage-depth-infinity branch 4 times, most recently from 3764258 to a2151b5 Compare November 20, 2023 06:17
@saw-jan saw-jan marked this pull request as ready for review November 20, 2023 06:18
@saw-jan saw-jan force-pushed the tests/test-coverage-depth-infinity branch from a2151b5 to 12844eb Compare November 21, 2023 11:08
PrajwolAmatya
PrajwolAmatya approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SagarGi
SagarGi approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan force-pushed the tests/test-coverage-depth-infinity branch from 12844eb to 99dd793 Compare November 27, 2023 09:04
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 334684f into master Nov 27, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the tests/test-coverage-depth-infinity branch November 27, 2023 10:09
ownclouders pushed a commit that referenced this pull request Nov 27, 2023
@saw-jan
extend depth:infinity enabled tests (#7397)
90dafed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwolAmatya PrajwolAmatya PrajwolAmatya approved these changes

@SagarGi SagarGi SagarGi approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saw-jan @SagarGi @PrajwolAmatya