Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Natsjs registry #7487

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Natsjs registry #7487

merged 6 commits into from
Nov 6, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Oct 13, 2023 •
edited
Loading

Introduces a natsjs based registry

Basic functionality works, but breaking bug:

To use natsjs based registry:

export MICRO_REGISTRY=natsjs # set natsjs as registry
export MICRO_REGISTRY_ADDRESS="127.0.0.1:9233" # set address for nats

@kobergj kobergj force-pushed the NatsJSRegistry branch 8 times, most recently from 0ed3551 to 4b24437 Compare October 20, 2023 09:29
@kobergj kobergj marked this pull request as ready for review October 30, 2023 12:56
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kobergj kobergj merged commit 65cea02 into owncloud:master Nov 6, 2023
1 check passed
@kobergj kobergj deleted the NatsJSRegistry branch November 6, 2023 15:36
ownclouders pushed a commit that referenced this pull request Nov 6, 2023
@kobergj
Merge pull request #7487 from kobergj/NatsJSRegistry
d557ab6 
Natsjs registry
@wkloucek wkloucek mentioned this pull request Nov 20, 2023
Merged
11 tasks
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2403905 2403905 2403905 approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek

@micbar micbar Awaiting requested review from micbar

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobergj @2403905