-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement sharing roles #7524
Merged
Merged
implement sharing roles #7524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2403905
force-pushed
the
issue-7418
branch
2 times, most recently
from
October 18, 2023 14:43
3e51619
to
b95ecea
Compare
@2403905 Would you mind adding a somewhat more descriptive test to the commit messages (and PR description) about what this actually does? That would be helpful for any possible reviwers. "implement sharing roles" is pretty sparse without any further context 😄 |
2403905
force-pushed
the
issue-7418
branch
2 times, most recently
from
October 19, 2023 17:50
75366c6
to
98671af
Compare
kobergj
requested changes
Oct 24, 2023
Kudos, SonarCloud Quality Gate passed! |
kobergj
approved these changes
Oct 24, 2023
ownclouders
pushed a commit
that referenced
this pull request
Oct 24, 2023
Co-authored-by: Roman Perekhod <[email protected]>
nabim777
pushed a commit
that referenced
this pull request
Oct 26, 2023
Co-authored-by: Roman Perekhod <[email protected]>
6 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two endpoints that map roles have been added
https://owncloud.dev/libre-graph-api/#/roleManagement
Redundant roles RoleUnknown, RoleLegacy, RoleDenied, RoleNone that have no permissions have been skipped.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: