Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Add test for rename and move the file between personal and share space using fileid #7637

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Nov 1, 2023

Description

This PR adds the test for naming and moving the files betweeen personal space and Shares space with the url consisting of the file-id not name

Related Issue

@nabim777
Copy link
Member Author

nabim777 commented Nov 1, 2023

This PR is blocked due to this issue #7618

@nabim777 nabim777 force-pushed the add-test-on-move-or-rename-between-fileID-Share-space-and-personal-space branch from 68efa37 to b9eec51 Compare November 22, 2023 04:02
@nabim777 nabim777 requested a review from SagarGi November 22, 2023 04:29
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nabim777 nabim777 force-pushed the add-test-on-move-or-rename-between-fileID-Share-space-and-personal-space branch 2 times, most recently from 176ffb2 to 323d543 Compare November 23, 2023 04:57
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nabim777 nabim777 force-pushed the add-test-on-move-or-rename-between-fileID-Share-space-and-personal-space branch from 323d543 to 9678adb Compare November 23, 2023 06:29
@nabim777 nabim777 force-pushed the add-test-on-move-or-rename-between-fileID-Share-space-and-personal-space branch from 9678adb to 0e660b2 Compare November 23, 2023 08:28
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nabim777 nabim777 merged commit 74f1b2c into master Nov 23, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the add-test-on-move-or-rename-between-fileID-Share-space-and-personal-space branch November 23, 2023 09:36
ownclouders pushed a commit that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants