Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Move locks related tests to local api tests and link the failing lock tests with correct issues #7643

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Nov 1, 2023

Description

Move locks related tests to local api tests and link the failing lock tests with correct issues

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT self-assigned this Nov 1, 2023
@SwikritiT SwikritiT marked this pull request as ready for review November 1, 2023 09:01
@SwikritiT SwikritiT marked this pull request as draft November 1, 2023 10:35
@SwikritiT SwikritiT force-pushed the tests/issue-7625/coreApiWebdavLocks branch 2 times, most recently from a70c94b to 03f322d Compare November 2, 2023 07:19
@SwikritiT SwikritiT changed the title [tests-only][full-ci]Link the failing lock tests with correct issues that they are failing with [tests-only][full-ci]Move locks related tests to local api tests and link the failing lock tests with correct issues Nov 2, 2023
@SwikritiT SwikritiT marked this pull request as ready for review November 2, 2023 07:20
@SwikritiT SwikritiT force-pushed the tests/issue-7625/coreApiWebdavLocks branch from 03f322d to 1ce3521 Compare November 2, 2023 08:30
@SwikritiT SwikritiT requested a review from saw-jan November 2, 2023 11:18
@SwikritiT SwikritiT mentioned this pull request Nov 2, 2023
7 tasks
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SwikritiT SwikritiT force-pushed the tests/issue-7625/coreApiWebdavLocks branch from f112968 to 708440a Compare November 3, 2023 09:39
@SwikritiT SwikritiT force-pushed the tests/issue-7625/coreApiWebdavLocks branch 3 times, most recently from e980c1f to 1e90cdc Compare November 17, 2023 06:34
@SwikritiT SwikritiT force-pushed the tests/issue-7625/coreApiWebdavLocks branch 2 times, most recently from ce75801 to 7d4a78e Compare November 17, 2023 08:42
@SwikritiT SwikritiT requested a review from saw-jan November 17, 2023 08:43
@SwikritiT SwikritiT force-pushed the tests/issue-7625/coreApiWebdavLocks branch from 7d4a78e to 592f9c9 Compare November 17, 2023 08:57
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT merged commit 792c8cc into master Nov 17, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the tests/issue-7625/coreApiWebdavLocks branch November 17, 2023 10:37
ownclouders pushed a commit that referenced this pull request Nov 17, 2023
…link the failing lock tests with correct issues (#7643)

* Link the failing lock tests with correct issues that they are failing with

* Move locks relates tests to new suite

Signed-off-by: Swikriti Tripathi <[email protected]>

* address reviews

Signed-off-by: Swikriti Tripathi <[email protected]>

* Add new scenario for trying to lock a folder

Signed-off-by: Swikriti Tripathi <[email protected]>

---------

Signed-off-by: Swikriti Tripathi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants