Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Add test for unlocking project space file #7698

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Nov 9, 2023

Description

This PR adds the test for unlocking project space file

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 force-pushed the add-tests-for-unlock-project-space branch from 1826350 to e13b274 Compare November 9, 2023 10:02
@nabim777
Copy link
Member Author

nabim777 commented Nov 9, 2023

This PR has an issue #7696

@nabim777 nabim777 self-assigned this Nov 9, 2023
@nabim777 nabim777 mentioned this pull request Nov 9, 2023
7 tasks
@nabim777 nabim777 force-pushed the add-tests-for-unlock-project-space branch 4 times, most recently from 55e084b to ab6e487 Compare November 16, 2023 06:46
@nabim777 nabim777 marked this pull request as ready for review November 16, 2023 07:01
@nabim777 nabim777 force-pushed the add-tests-for-unlock-project-space branch from ab6e487 to 30f99bf Compare November 16, 2023 07:09
And user "Alice" has uploaded a file inside space "project-space" with content "some data" to "textfile.txt"
And user "Alice" has locked file "textfile.txt" inside space "project-space" setting the following properties
| lockscope | <lock-scope> |
When user "Alice" unlocks the last created lock of file "textfile.txt" inside space "project-space" using the WebDAV API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we already have coverage for locking project space file?

Copy link
Member Author

@nabim777 nabim777 Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to search but could not find so I think there is no coverage for locking and unlocking project spaces

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I would suggest adding locking and unlocking tests

Copy link
Contributor

@SwikritiT SwikritiT Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is some coverage for locking the project space file

Scenario Outline: lock a file in the project space

Scenario Outline: lock a file in the project space using file-id

Scenario: viewer cannot lock a file in the project space

For the first batch of lock/unlock tests IMO we can shift the tests from core to ocis and provide the coverage for unlock as per there is coverage for locking and other edge cases can be added later or in other PR

Comment on lines 154 to 188
- [apiLocks/unlockFiles.feature:21](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiLocks/unlockFiles.feature#L21)
- [apiLocks/unlockFiles.feature:22](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiLocks/unlockFiles.feature#L22)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScharfViktor do we wait for fix or just keep it here for now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let keep it here. I ask fix it on the next week

@nabim777 nabim777 force-pushed the add-tests-for-unlock-project-space branch 4 times, most recently from 1778207 to aa6ef4a Compare November 21, 2023 03:38
@nabim777 nabim777 requested a review from SwikritiT November 21, 2023 04:05
@nabim777 nabim777 force-pushed the add-tests-for-unlock-project-space branch from aa6ef4a to 1a52781 Compare November 21, 2023 04:10
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT merged commit 111dbb3 into master Nov 21, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the add-tests-for-unlock-project-space branch November 21, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants