-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] Add test for unlocking project space file #7698
Conversation
1826350
to
e13b274
Compare
|
55e084b
to
ab6e487
Compare
ab6e487
to
30f99bf
Compare
And user "Alice" has uploaded a file inside space "project-space" with content "some data" to "textfile.txt" | ||
And user "Alice" has locked file "textfile.txt" inside space "project-space" setting the following properties | ||
| lockscope | <lock-scope> | | ||
When user "Alice" unlocks the last created lock of file "textfile.txt" inside space "project-space" using the WebDAV API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we already have coverage for locking project space file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try to search but could not find so I think there is no coverage for locking and unlocking project spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I would suggest adding locking and unlocking tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is some coverage for locking the project space file
Scenario Outline: lock a file in the project space |
Scenario Outline: lock a file in the project space using file-id |
Scenario: viewer cannot lock a file in the project space |
For the first batch of lock/unlock tests IMO we can shift the tests from core to ocis and provide the coverage for unlock as per there is coverage for locking and other edge cases can be added later or in other PR
- [apiLocks/unlockFiles.feature:21](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiLocks/unlockFiles.feature#L21) | ||
- [apiLocks/unlockFiles.feature:22](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiLocks/unlockFiles.feature#L22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ScharfViktor do we wait for fix or just keep it here for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let keep it here. I ask fix it on the next week
30f99bf
to
a1eeb14
Compare
1778207
to
aa6ef4a
Compare
aa6ef4a
to
1a52781
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Description
This PR adds the test for unlocking project space file
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: