bump reva to latest edge #7727
Merged
bump reva to latest edge #7727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
rhafer
force-pushed
the
libregraph-permissions
branch
from
af26219 to
5911460
Compare
kobergj
approved these changes
Nov 15, 2023
rhafer
force-pushed
the
libregraph-permissions
branch
from
5911460 to
f3f6b9b
Compare
2403905
approved these changes
Nov 15, 2023
|
cs3org/reva#4343 should fix the failing test |
rhafer
force-pushed
the
libregraph-permissions
branch
from
f3f6b9b to
357c9d7
Compare
|
@micbar @fschade I am not really sure if the current failure is a bug in the code (reva) or in the tests. Is the receiver for a share (with edit role) supposed to be able to see the existing file versions? Then our viewer and editor roles lack the |
fschade
force-pushed
the
libregraph-permissions
branch
from
295af8f to
4a7204a
Compare
The UnifiedRole related types are pretty specific to the graph service. Maintaining them as part of reva makes things more complex that required.
fschade
force-pushed
the
libregraph-permissions
branch
from
4a7204a to
458cf2a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ownclouders
pushed a commit
that referenced
this pull request
Nov 17, 2023
* bump reva to latest edge To get cs3org/reva#4336 * graph: Import unified role related code from reva The UnifiedRole related types are pretty specific to the graph service. Maintaining them as part of reva makes things more complex that required. * chore: add failing cases to the expected failures --------- Co-authored-by: Florian Schade <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.