graph: implement delete permission for link permissions #7849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The handling of 'error' has been moved from FromStat() to FromCS3Status(). It's generally useful for other users of FromCS3Status()
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
rhafer
commented
Nov 29, 2023
| @@ -154,6 +154,10 @@ func (e Error) Error() string { | |||
| return errString | |||
| } | |||
|
|
|||
| func (e Error) GetCode() ErrorCode { | |||
| return e.errorCode | |||
| } | |||
There was a problem hiding this comment.
I am not too happy with this. I think ideally we would use properly typed errors. This would all using things like errors.Is(graph.ErrorItemNotFound).
However it requires quite a bit of refactoring, so I am still pondering if that is worth it.
Allow to delete link permissions (i.e. Public Shares)
rhafer
force-pushed
the
graph-delete-permission
branch
from
c7215e1 to
c487a61
Compare
|
Kudos, SonarCloud Quality Gate passed! |
fschade
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DELETE on graph/v1beta1/drives//items//permissions/ for link permissions (public shares)