graph: update permissions #7860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
rhafer
force-pushed
the
graph-update-permissions
branch
from
211e98d to
7f3354b
Compare
|
needs: cs3org/reva#4388 |
rhafer
force-pushed
the
graph-update-permissions
branch
3 times, most recently
from
6d1b7e3 to
f70c415
Compare
rhafer
force-pushed
the
graph-update-permissions
branch
from
f70c415 to
3591d64
Compare
micbar
reviewed
Dec 8, 2023
micbar
approved these changes
Dec 8, 2023
rhafer
force-pushed
the
graph-update-permissions
branch
from
3591d64 to
6c63803
Compare
Otherwise errorcode.RenderError() will not render the correct HTTP Status
This is an initial implementation of PATCH support on drives/{driveid}/items/{itemid}/permissions/{id}.
It focusses on updating user shares for now. It's possible to update the
expirationDate, roles and/or libregraphResourceActions.
Updating the permissions of a space root or a public link share is currently
not implemeted.
rhafer
force-pushed
the
graph-update-permissions
branch
from
6c63803 to
269ce60
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of PATCH support on drives/{driveid}/items/{itemid}/permissions/{id}.
It focusses on updating user shares for now. It's possible to update the expirationDate, roles and/or libregraphResourceActions.
Updating the permissions of a space root or a public link share is currently not implemented. Both should come with a follow up PR.
Somehow the usershareprovider is also still lacking checks if the sharer is actually allowed to set the requested permissions (e.g. when re-sharing). Still need to investigate that, but that something for a reva PR.