Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config var UserListRequiresFilter #7866

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Add config var UserListRequiresFilter #7866

merged 3 commits into from
Dec 1, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Dec 1, 2023 •
edited
Loading

Description

Introduce a config to require filters in order to list users in Web via WEB_OPTION_USER_LIST_REQUIRES_FILTER.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@AlexAndBear AlexAndBear requested a review from kulmann as a code owner December 1, 2023 09:21
@update-docs Update Docs
Copy link

update-docs bot commented Dec 1, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

kulmann
kulmann previously approved these changes Dec 1, 2023
View reviewed changes
services/web/pkg/config/options.go Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear force-pushed the add-config-var-user-list-requires-filter branch from 85118bf to 7697e07 Compare December 1, 2023 09:34
@AlexAndBear AlexAndBear requested a review from kulmann December 1, 2023 09:38
@AlexAndBear AlexAndBear force-pushed the add-config-var-user-list-requires-filter branch from fb3caa3 to 4f26616 Compare December 1, 2023 09:48
@AlexAndBear AlexAndBear dismissed kulmann’s stale review December 1, 2023 10:59

Couldn't resolve white space issue display issue?

@mmattel
Update options.go
99280bf 
Co-authored-by: Martin <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel
Copy link
Contributor

mmattel commented Dec 1, 2023 •
edited
Loading

Q: the criteria adding one filter at minimum is satisfied if one filter has been used, ok.
Do we check if the filter uses * (if that is allowed) - means all users? Else adding a filter becomes senseless...

@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Dec 1, 2023 •
edited
Loading

Q: the criteria adding a filter is satisfied if one filter has been used, ok. Do we check if the filter does not allow * (if that is allowed) - means all users? Else adding a filter becomes senseless...

This has nothing to do with this pr. We do allow * but this won't fire a wildcard search but will expose users that have * in their names.

mmattel
mmattel approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a doc pov 👍

kobergj
kobergj approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is blocking we can update the description later if needed

@AlexAndBear AlexAndBear merged commit 263cb21 into master Dec 1, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-config-var-user-list-requires-filter branch December 1, 2023 12:30
@mmattel
Copy link
Contributor

mmattel commented Dec 1, 2023

We do allow * but this won't fire a wildcard search but will expose user that has * in their names.

aha... I would have never taken this into consideration...

ownclouders pushed a commit that referenced this pull request Dec 1, 2023
@mmattel
Add config var UserListRequiresFilter (#7866)
37bf2e0 
* Add config var UserListRequiresFilter

* Fix whitespace

* Update options.go

Co-authored-by: Martin <[email protected]>

---------

Co-authored-by: Martin <[email protected]>
2403905 pushed a commit to 2403905/ocis that referenced this pull request Dec 8, 2023
@mmattel @2403905
Add config var UserListRequiresFilter (owncloud#7866)
52ced7b 
* Add config var UserListRequiresFilter

* Fix whitespace

* Update options.go

Co-authored-by: Martin <[email protected]>

---------

Co-authored-by: Martin <[email protected]>
@wkloucek wkloucek mentioned this pull request Dec 11, 2023
Merged
11 tasks
@micbar micbar mentioned this pull request Dec 12, 2023
Merged
12 tasks
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
@mmattel @2403905
Add config var UserListRequiresFilter (owncloud#7866)
7607a78 
* Add config var UserListRequiresFilter

* Fix whitespace

* Update options.go

Co-authored-by: Martin <[email protected]>

---------

Co-authored-by: Martin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel approved these changes

@kobergj kobergj kobergj approved these changes

@2403905 2403905 2403905 approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexAndBear @mmattel @kulmann @2403905 @kobergj