Edit public links and setPassword #7908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
micbar
force-pushed
the
edit-public-links
branch
from
1b14bef to
cd79b7b
Compare
micbar
force-pushed
the
edit-public-links
branch
from
a976ccb to
ccd0f39
Compare
micbar
force-pushed
the
edit-public-links
branch
from
fe84f46 to
33feab8
Compare
micbar
commented
Dec 11, 2023
| @@ -45,7 +45,7 @@ func FromCS3Status(status *cs3rpc.Status, inerr error, ignore ...cs3rpc.Code) *E | |||
| case code == cs3rpc.Code_CODE_ALREADY_EXISTS: | |||
| err.errorCode = NameAlreadyExists | |||
| case code == cs3rpc.Code_CODE_FAILED_PRECONDITION: | |||
| err.errorCode = PreconditionFailed | |||
| err.errorCode = InvalidRequest | |||
There was a problem hiding this comment.
@rhafer I needed to fix that. We had misunderstandings about that CS3 Status already in the past.
micbar
commented
Dec 11, 2023
| @@ -135,6 +135,8 @@ func (e Error) Render(w http.ResponseWriter, r *http.Request) { | |||
| status = http.StatusMethodNotAllowed | |||
| case ItemIsLocked: | |||
| status = http.StatusLocked | |||
| case PreconditionFailed: | |||
There was a problem hiding this comment.
this was missing, added it in case we need it.
|
Kudos, SonarCloud Quality Gate passed! |
rhafer
approved these changes
Dec 12, 2023
ownclouders
pushed a commit
that referenced
this pull request
Dec 12, 2023
Edit public links and setPassword
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
Improve our APIs 🎉
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: