Remove privacyURL and imprintURL from config #7938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
lookacat
suggested changes
Dec 12, 2023
changelog/unreleased/change-remove-privacy-url-and-imprint-url-from-config
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
ownclouders
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Remove privacyURL and imprintURL from config * Add changelog item, fix typo * React on code review
12 tasks
2403905
pushed a commit
to 2403905/ocis
that referenced
this pull request
Jan 24, 2024
* Remove privacyURL and imprintURL from config * Add changelog item, fix typo * React on code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've removed PrivacyURL and ImprintURL from the config, hence these were living in Web config options,
other clients shouldn't consume those.
In order to be accessible by other clients, not just Web, those should be configured via the theme.json file.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: