Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Postprocessing Bulk restart #8287

Merged
merged 4 commits into from
Jan 26, 2024
Merged

[full-ci] Postprocessing Bulk restart #8287

merged 4 commits into from
Jan 26, 2024

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jan 25, 2024

Allows restarting all uploads currently in a specific postprocessing step

@kobergj kobergj force-pushed the PostprocessingBulkRestart branch from ee46ae2 to 2f3e8cb Compare January 25, 2024 11:35
@kobergj kobergj mentioned this pull request Jan 25, 2024
Merged
butonic
butonic suggested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@butonic butonic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README.md regarding how to restart all uploads in a given step.

Also, there is no command to get a list of the state every upload is in, right? We could look into external stores, but the default memory does not work, right? Hm, for in memory all ongoing uploads are lost ... and there is no way cli to pick up the upload sessions from disk again. they can only be cleaned. Shoud we change the default to nats-js-kv?

Ah ok, by giving the upload-id the postprocessing can always be restarted ...

@kobergj kobergj force-pushed the PostprocessingBulkRestart branch from 3659dd1 to b7635f5 Compare January 26, 2024 14:22
@kobergj kobergj enabled auto-merge January 26, 2024 14:30
This was referenced Jan 26, 2024
Closed
Closed
@kobergj kobergj changed the title Postprocessing Bulk restart [full-ci] Postprocessing Bulk restart Jan 26, 2024
@saw-jan
Copy link
Member

saw-jan commented Jan 26, 2024

Need to adjust MOVE related API test expectations again. I could have pushed the changes but the PR is from the fork

@kobergj
Copy link
Collaborator Author

kobergj commented Jan 26, 2024 •
edited
Loading

@saw-jan I added you to the fork. Can you accept the invite and retry?

@saw-jan
Copy link
Member

saw-jan commented Jan 26, 2024

Need to adjust MOVE related API test expectations again. I could have pushed the changes but the PR is from the fork

Thanks, I will push the test changes

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@saw-jan
Copy link
Member

saw-jan commented Jan 26, 2024

Updated the tests. 👍 from the CI. ✨

@kobergj kobergj merged commit c37ed59 into owncloud:master Jan 26, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Jan 26, 2024
@kobergj
Merge pull request #8287 from kobergj/PostprocessingBulkRestart
41ca107 
Postprocessing Bulk restart
@micbar micbar mentioned this pull request Jan 26, 2024
Closed
71 tasks
@rhafer rhafer mentioned this pull request Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kobergj @saw-jan @butonic @micbar