Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add epub-reader to apps default config #8410

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Add epub-reader to apps default config #8410

merged 2 commits into from
Feb 23, 2024

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@AlexAndBear AlexAndBear requested a review from kulmann as a code owner February 8, 2024 15:21
@update-docs Update Docs
Copy link

update-docs bot commented Feb 8, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar enabled auto-merge February 8, 2024 15:24
kulmann
kulmann suggested changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the ocis master is currently not allowed to receive an oC Web master version, we can't merge this PR. Needs to sit here until we can bring oC Web master to oCIS master.

@AlexAndBear AlexAndBear force-pushed the add-epub-reader-to-apps-default-config branch from 04b8e69 to b830e0e Compare February 9, 2024 08:04
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear disabled auto-merge February 9, 2024 09:12
@micbar micbar requested a review from kulmann February 20, 2024 22:20
kulmann
kulmann approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go

@micbar
Copy link
Contributor

micbar commented Feb 23, 2024

🏃

@AlexAndBear AlexAndBear merged commit 48a4114 into master Feb 23, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-epub-reader-to-apps-default-config branch February 23, 2024 14:19
ownclouders pushed a commit that referenced this pull request Feb 23, 2024
Add epub-reader to apps default config (#8410)
5358686
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @micbar @kulmann