Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] fix MOVE with another user dav path scenarios #8460

Merged
merged 4 commits into from
Feb 19, 2024
Merged

[tests-only] fix MOVE with another user dav path scenarios #8460

merged 4 commits into from
Feb 19, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Feb 15, 2024 •
edited
Loading

Description

Tests fixed according to #3882 (comment)

So I just tested this and requests to another users resources now always return 404.
I also opened a PR for the request body check: cs3org/reva#2974

Related Issue

Part of #8440
Tests fix for #3882

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Feb 15, 2024
This was referenced Feb 15, 2024
Closed
Closed
@saw-jan saw-jan force-pushed the tests/fix-MOVE-another-user-scenario branch 2 times, most recently from 5331ef8 to 83b07dd Compare February 16, 2024 10:07
@saw-jan saw-jan marked this pull request as ready for review February 16, 2024 10:07
@saw-jan saw-jan force-pushed the tests/fix-MOVE-another-user-scenario branch from 83b07dd to 0a1fbc7 Compare February 19, 2024 08:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ScharfViktor
ScharfViktor approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit 0df64c2 into master Feb 19, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/fix-MOVE-another-user-scenario branch February 19, 2024 10:01
ownclouders pushed a commit that referenced this pull request Feb 19, 2024
@saw-jan
[tests-only] fix MOVE with another user dav path scenarios (#8460)
fd6725b 
* test(api): fix MOVE with another user dav path scenarios

* test(api): fix php code style

* test(api): fix dav paths

* test(api): fix dav paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saw-jan @ScharfViktor