fix the docker-compose wopi

[2403905]

Description

Related Issue

• Fixes Collabora is not available #8474

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[micbar]

I would rather try to find a solution wihout the curl workaround in the entrypoint override.

This example is used by community for production deployments.

Can we use the compose depends_on logic here?

[2403905]

@micbar
The depends_on will work correctly if we use it with the condition service_healthy and in this case we have to perform the healthcheck somehow in a collabora and onlyoffice.
https://docs.docker.com/compose/compose-file/compose-file-v3/#healthcheck

services:
  ocis-appprovider-collabora:
    image: ocis
    depends_on:
      collabora:
        condition: service_healthy
        
  collabora:
    image: collabora
    healthcheck:
      test: ["CMD", "curl", "-f", "http://localhost"]
      interval: 1s
      timeout: 3s
      retries: 30

upd: https://sdk.collaboraonline.com/docs/installation/CODE_Docker_image.html#troubleshooting

[2403905]

So in both cases, we must add a curl in the app provider or in the office client container. I would prefer not to change the office client containers.

[wkloucek]

Is this a duplicate of #8144 ?

Instead of working around it, we should properly fix it: #3832 (comment)

[2403905]

Looks like it is a duplicate of #8144

[butonic]

how do we move forward?

[wkloucek]

@kulmann I already reviewed it:

Instead of working around it, we should properly fix it: #3832 (comment)

[DeepDiver1975]

Tested ✔️ and collabora shows up in the file action menu right away and it can be opened.
But it cries about no disk space .... but I guess this is unrelated

[2403905]

It works well for me!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[DeepDiver1975]

tested again after rebase - collabora is shown in the file action menu right away.
but i still get the disk space issue - but this is a different ropic.

let's merge this ...

The same workaround has already been applied to OnlyOffice as well.

[micbar]

No!
I was against merging that.

You put user:0 on the container which is a total no go.

Please revert.

[DeepDiver1975]

but then you need to revert onlyoffice as well and the whole example is useless.

introduced 3 years ago - https://github.com/owncloud/ocis/blame/76f97ba0c430f1fd5f0465bf78149149d27c468d/deployments/examples/ocis_wopi/docker-compose.yml#L148

@micbar

[wkloucek]

Which brings us back to #3832

But there is also another workaround:

healthcheck:
  test:
    - CMD
    - /bin/sh
    - -c
    - curl --silent -- fail http://ocis:9200/app/list | grep '"name":"Collabora"'

It similar to the workaround in the oCIS Helm Chart: https://github.com/owncloud/ocis-charts/blob/ca7f57a448adfd2aed3c28e1b0c0146d226547ae/charts/ocis/templates/appprovider/deployment.yaml#L88-L93

This actually also "works" for the case that you're restarting the appregistry.

[DeepDiver1975]

#8984