always select next before making calls #8578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
force-pushed
the
next-before-making-calls
branch
from
44d86ce to
a183040
Compare
|
sonarcloud is unhappy with the error handling here: https://github.com/owncloud/ocis/pull/8578/files#diff-d172341b09d843bfd4ed2855577a4d501da7fe3792103ad56be1d26f1876fd84L215-L222 I agree ... shouldn't we return an error? I don't want to change the behavior so I'd still prefer to merge this as is. We can look into that in a separate PR |
kobergj
requested changes
Apr 2, 2024
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
next-before-making-calls
branch
from
573ecbc to
6f897ef
Compare
|
ownclouders
pushed a commit
that referenced
this pull request
Apr 10, 2024
always select next before making calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #8570 I went over other places in ocis that use the selector and client. We now select the next client more often to spread out load.
I don't expect a huge impact from this PR.